Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove some superfluous unsafe code #3297

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove some superfluous unsafe code #3297

wants to merge 1 commit into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Dec 11, 2021

Objective

  • This unsafe is weird

Solution

  • Don't use unsafe here

Hopefully this isn't already in an open PR.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 11, 2021
@mockersf mockersf added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Dec 11, 2021
alice-i-cecile
alice-i-cecile approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much easier to follow, seems equivalent and removing weird unsafe is good. LGTM!

@bjorn3 bjorn3 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Dec 11, 2021
@cart
Copy link
Member

cart commented Dec 11, 2021

Looks good to me. An uncontroversial win!

@cart
Copy link
Member

cart commented Dec 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2021
@DJMcNab
Remove some superfluous unsafe code (#3297)
0ee4195 
# Objective

- This `unsafe` is weird

## Solution

- Don't use `unsafe` here

Hopefully this isn't already in an open PR.
@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove some superfluous unsafe code [Merged by Bors] - Remove some superfluous unsafe code Dec 11, 2021
@bors bors bot closed this Dec 11, 2021
@DJMcNab DJMcNab deleted the why_why_why branch December 12, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Ratysz Ratysz Ratysz approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DJMcNab @cart @Ratysz @alice-i-cecile @bjorn3 @mockersf